Add docker deployment #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nore to enable deploying the stack easily with docker. I added a change in the helper.ts to enable to define the backend URL through the BACKEND_URL environment variable (it defaults to http://localhost:3000 if the variable is not defined)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request add the files required to easily deploy LDShapes from the source code using
docker-compose:backend/Dockerfilefrontend/Dockerfiledocker-compose.yml.dockerignoreI also made a change to the
helper.tsfile to get the backend URL from theBACKEND_URLenvironment variable (you might want to test this works properly with your local deployment)And added instructions to deploy with
docker-compose upin theREADME.mdCurrently it is built to be able to quickly build and start LDShapes in docker containers, and avoid versioning errors (cf. #16). It could be improved to be more optimized for production deployments or development settings depending of the use people want to have with it