Regarding Issue #313 #314
Closed
Regarding Issue #313 #314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor changes that resolve both problems as stated in issue vitch#313 Normal behaviour remains for me, though I am unsure if I know your application well enough – shouldn't raise problems though. All Changes commented with a reference to the issue. Didn't wrap "$(document).mouseup();" in a function as it's minor and self-explanatory, imho it may remain in an anonymous function.
Namespaces added mouseup-events Added unbind on elem-mouseup-event in destroy()
|
Neither return false nor e.stopPropagation() make a differencen there, tested both. |
|
Is this jQuery 3.0 compatible? |
|
No feedback over year and can't preproduce this problem also no jQuery 3.0 compability. Reopen if this is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor changes that resolve both problems as stated in issue #313
Normal behaviour remains for me, though I am unsure if I know your application well enough – shouldn't raise problems though.
All Changes commented with a reference to the issue.
Didn't wrap "$(document).mouseup();" in a function as it's minor and self-explanatory, imho it may remain in an anonymous function.