Bash functions after EXPORT_FUNCTIONS and addtask statements, bitbake flags in combination with overrides #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@moqmar maybe you can have a look? |
|
We might have a minor issue now when an addtask or EXPORT_FUNCTIONS statement appears at the end of a file with no CRLF token at the end.... Investigating... |
Previously the parser/highlighter failed in the following two
situations:
First:
addtask taskname before anothertask
bashfn() {
:
}
Second:
EXPORT_FUNCTIONS functionname
bashfn() {
:
}
The reason is that both lexer rules (= ADD_TASK_STATEMENT,
EXPORT_FUNC_STATEMENT) end with one BB_FUNCTION_NAME token.
The name of the bash function is also a BB_FUNCTION_NAME token and
therefor valid for the bbAddTaskStatement and bbExportFuncStatement
rules. The parser allowed the function name but failed on the opening
bracket.
Fixed by clearly terminating with CRLF tokens.
Signed-off-by: Florian Bezdeka <[email protected]>
The following could not be parsed / highlighted correctly:
variable:override[attribute] += "value"
variable:override:override[attribute] += "value"
Signed-off-by: Florian Bezdeka <[email protected]>
That is fixed now... Waiting for review... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the commit messages explain everything in detail.
2 fixes: