-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ts conversion #41
base: clerk-authentication
Are you sure you want to change the base?
ts conversion #41
Conversation
Someone is attempting to deploy a commit to a Personal Account owned by @vishwajeetraj11 on Vercel. @vishwajeetraj11 first needs to authorize it. |
import spin from './loader.module.css'; | ||
|
||
const Loader = ({ fullScreen }) => ( | ||
const Loader = ({ fullScreen }: { fullScreen: boolean }) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move these types to interface
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
as in like this
interface LoaderProps {
fullScreen: boolean
}```
import { NoFilesFoundSVG } from './SVGs'; | ||
|
||
const NoDocumentFound = ({ text }) => ( | ||
const NoDocumentFound = ({ text }: { text: string }) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move these types to interface
@@ -32,10 +32,10 @@ const sections = [ | |||
}, | |||
]; | |||
|
|||
const RightSideBar = ({ handlePrint }) => { | |||
const RightSideBar = ({ handlePrint }: { handlePrint: () => void }) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move these types to interface
id: string; | ||
} | ||
|
||
const ExtrasCard = ({ title, type, items, onDelete, openEditExtForm, extraActive, id }: ExtrasCardTypes) => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move these types to interface
|
||
const TemplateCard = ({ template, selected, onSelect, type }) => ( | ||
const TemplateCard = ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
move these types to interface
if (clone[id]) { | ||
setEducationActive(p => ({ | ||
setEducationActive((p: any) => ({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use proper types instead of any
@@ -123,7 +128,7 @@ const ReorderEducation = ({ closeDrawer, anchor, type }) => { | |||
// create an object that will be passed as in state | |||
// which we will use to disable the rest state (false) | |||
// this will ensure at one time only one is active | |||
const fakeState = {}; | |||
const fakeState: any = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use proper types instead of any
@@ -153,21 +159,21 @@ const ReorderEducation = ({ closeDrawer, anchor, type }) => { | |||
// create an object that will be passed as in state | |||
// which we will use to disable the rest state (false) | |||
// this will ensure at one time only one is active | |||
const fakeState = {}; | |||
const fakeState: any = {}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use proper types instead of any
};
getting ts error in component/ drag&drop/ ReorderExperience
const getItemStyle = (isDragging: boolean, draggableStyle?: React.CSSProperties) => ({
getting ts error in component/ drag&drop/ ReorderExperience
api and leftSideBar has no yet been converted to ts.