Add support for vDPA devices management #939
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrianchiris
approved these changes
Jan 22, 2024
| nl.NewRtAttr(nl.VDPA_ATTR_MGMTDEV_DEV_NAME, nl.ZeroTerminated(mgmtName)), | ||
| } | ||
| if mgmtBus != "" { | ||
| attrs = append(attrs, nl.NewRtAttr(nl.VDPA_ATTR_MGMTDEV_BUS_NAME, nl.ZeroTerminated(mgmtBus))) |
There was a problem hiding this comment.
mgmt bus is not mandatory ?
There was a problem hiding this comment.
yes, for some devices it can be not set
| attrs = append(attrs, | ||
| nl.NewRtAttr(nl.VDPA_ATTR_MGMTDEV_DEV_NAME, nl.ZeroTerminated(*dev)), | ||
| ) | ||
| if bus != nil { |
There was a problem hiding this comment.
bus is not mandatory if dev is provided ?
There was a problem hiding this comment.
yes, example is vdpa_sim device. It doesn't have a bus
|
@lmilleri PTAL |
|
Unless each commit brings in a independent feature/fix, please have one commit per PR. We have been following this logic in this repo. |
Current implementation support following functions: - VDPANewDev - VDPADelDev - VDPAGetDevList - VDPAGetDevByName - VDPAGetDevConfigList - VDPAGetDevConfigByName - VDPAGetDevVStats - VDPAGetMGMTDevList - VDPAGetMGMTDevByBusAndName Signed-off-by: Yury Kulazhenkov <[email protected]>
ykulazhenkov
force-pushed
the
vdpa-support
branch
from
4064b4d
to
63de758
Compare
Thank you @aboch, |
|
@aboch @vishvananda could you take a look at this PR ? :) |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vDPA - virtio Data Path Acceleration
Following functions are supported by the implementation:
VDPANewDev - adds new VDPA device
Equivalent to:
vdpa dev add name <name> mgmtdev <mgmtBus>/<mgmtName> [params]VDPADelDev removes VDPA device
Equivalent to:
vdpa dev del <name>VDPAGetDevList returns list of VDPA devices
Equivalent to:
vdpa dev showVDPAGetDevByName returns VDPA device selected by name
Equivalent to:
vdpa dev show <name>VDPAGetDevConfigList returns list of VDPA devices configurations
Equivalent to:
vdpa dev config showVDPAGetDevConfigByName returns VDPA device configuration selected by name
Equivalent to:
vdpa dev config show <name>VDPAGetDevVStats returns vstats for VDPA device
Equivalent to:
vdpa dev vstats show <name> qidx <queueIndex>VDPAGetMGMTDevList returns list of mgmt devices
Equivalent to:
vdpa mgmtdev showVDPAGetMGMTDevByBusAndName returns mgmt devices selected by bus and name
Equivalent to:
vdpa mgmtdev show <bus>/<name>