Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for get devlink resource #936

Merged
merged 2 commits into from
Jan 22, 2024

Conversation

adrianchiris
Copy link
Collaborator

This PR adds support for devlink resource objects.

@adrianchiris
Copy link
Collaborator Author

depends on #935

@adrianchiris adrianchiris changed the title Add devlink resource Add support for get devlink resource Dec 6, 2023
Copy link
Contributor

@ykulazhenkov ykulazhenkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, tested on my env works well.
LGTM

This will allow to parse nl attributes, returning a map
for easy access to each attribute.

Signed-off-by: adrianc <[email protected]>
- Update nl package with new netlink attribute types and consts
- Define structs to model devlink device resources
- Add DevlinkGetDeviceResources method to return device resources
- Add basic test

Signed-off-by: adrianc <[email protected]>
@adrianchiris
Copy link
Collaborator Author

thx for testing this out @ykulazhenkov

rebased against latest main.

@aboch @vishvananda PTAL when you get a chance :)

@aboch
Copy link
Collaborator

aboch commented Jan 22, 2024

LGTM

@aboch aboch merged commit 36b61ad into vishvananda:main Jan 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants