Add support for the expires option of ip route
#1027
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is implemented through the attributes RTA_EXPIRES and RTA_CACHEINFO.
aboch
reviewed
Nov 5, 2024
| @@ -115,6 +128,9 @@ func (r Route) String() string { | |||
| elems = append(elems, fmt.Sprintf("Flags: %s", r.ListFlags())) | |||
| elems = append(elems, fmt.Sprintf("Table: %d", r.Table)) | |||
| elems = append(elems, fmt.Sprintf("Realm: %d", r.Realm)) | |||
| if r.Expires != 0 { | |||
| elems = append(elems, fmt.Sprintf("Expires: %dsec", r.Expires)) | |||
There was a problem hiding this comment.
should we put a space b/w before "sec"?
There was a problem hiding this comment.
This format is inherited from the ip route command. Note that the value can be negative because the kernel removes expired entries in a garbage collecting style.
aboch
reviewed
Nov 5, 2024
Enhanced TestRoute6AddDel with expiry option. Route expiry is only supported for IPv6 with kernel 4.4+.
|
Thanks @albertjin pls squash the two commits into one and push again. |
Link: https://lore.kernel.org/bpf/[email protected]/T/#u Add support for the `expires` option of `ip route` This is implemented through the attributes RTA_EXPIRES and RTA_CACHEINFO. Add testing code for the route expiry option Enhanced TestRoute6AddDel with expiry option. Route expiry is only supported for IPv6 with kernel 4.4+.
I made a mistake in squashing and gave up. Simply recreated a pull request #1029 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented through the attributes RTA_EXPIRES and RTA_CACHEINFO.