Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ci bump #1025

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Ci bump #1025

wants to merge 4 commits into from

Conversation

kolyshkin
Copy link

@kolyshkin kolyshkin commented Oct 22, 2024

Please see individual commit messages for details. High level overview:

  • bump github actions to latest versions
  • add build step to ensure everything is buildable
  • use go test -exec sudo to speed up test running
  • ci/gha: test on different Go and Ubuntu versions

Bump
 - actions/checkout v2 -> v4
 - actions/setup-go v2 -> v5

Signed-off-by: Kir Kolyshkin <[email protected]>
Make sure CI builds everything that is (or will be) there to build.

In particular, this ensures that cmd/ipset-test is buildable.

Signed-off-by: Kir Kolyshkin <[email protected]>
Running "sudo go test" results in a different environment, so go has to
recompile everything again.

Use "go test -exec sudo" so test would compile as current user (so that
go build cache is reused), then run as root.

The arguments added to sudo are:
 -n: do not ask for password
 --preserve-env CI,PATH: preserve these environment variables

Signed-off-by: Kir Kolyshkin <[email protected]>
Add test matrix to run tests on latest Go and different Ubuntu versions

Signed-off-by: Kir Kolyshkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant