Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links are now editable #1391

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Links are now editable #1391

merged 3 commits into from
Nov 22, 2024

Conversation

danv61
Copy link
Contributor

@danv61 danv61 commented Nov 21, 2024

Links are now editable, coordinates will be recalculated
Cosmetic fixes, rendering precision for coordinates and links rendering truncated to angstrom (one decimal unit)
In the table cell renderer the ColumType enum is recovered by column label instead of by column index (because some columns might have been moved around or removed at runtime)

dan-ss-links branch

@danv61 danv61 added the SpringSaLaD SpringSaLaD integration in VCell label Nov 21, 2024
@danv61 danv61 requested a review from jcschaff November 21, 2024 20:49
@danv61 danv61 self-assigned this Nov 21, 2024
Copy link
Member

@jcschaff jcschaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great Dan, only comment is to remove commented out code unless you REALLY think that you'll use it soon. Approved.

@danv61 danv61 merged commit 048f6a6 into master Nov 22, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SpringSaLaD SpringSaLaD integration in VCell
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants