[WIP] JsonSchema Validation #26

vjspranav · 2021-06-04T09:09:47Z

Referencing Schema Validation #25

* Referencing #25

raj-vlabs

I was thinking if it's worth to provide functionality for testing multiple files in one go. For example:
validate-schema file1.json file2.json
or
validate-schema file1.json file2.json schema.json

I think it will be too much work for not so much of utility. For this we probably have to specify a flag to indicate if the argument is a file or a schema, which will be too much work unless we use a library.
Can you quickly spend some time in finding out any node libraries which would read and parse command line arguments easily?

raj-vlabs · 2021-06-04T10:04:17Z

validation/validate.js

@@ -0,0 +1,43 @@
+const Ajv = require('ajv');
+const path = require('path');
+const schemaMap = require('./schemaMap.json')


Does using ES6 style imports work with this version of node? If it does, please use that instead of the commonjs require.

raj-vlabs · 2021-06-04T10:07:09Z

validation/validate.js

+            json = process.argv[2];
+            json = json.replace('/', '\\')
+            let n = json.lastIndexOf('\\');
+            let jsonKey = json.substring(n + 1);


Instead of string processing, please find a function in the fsx (file system) module which will take a path and will give you back the file name.

raj-vlabs · 2021-06-04T10:16:51Z

validation/validate.js

+            validateSchema(json, schema);
+            break
+        default:
+            console.log("Error")


It'd be good to print the correct usage information here instead of just printing Error.
Usage:

* schemaMap.json -> schema-map.json

* npm run validate-schema -f prestest.json * npm run validate-schema -f pretest.json posttest.json * npm run validate-schema -f test.json -s ./schemas/quizv2Schema.js

* Support for conditional version * Reference schema from external files

validation/validate.js

raj-vlabs · 2021-06-07T12:39:03Z

validation/validate.js

+    case 3:
+      json = process.argv[2];
+      json = json.replace("/", "\\");
+      let n = json.lastIndexOf("\\");


Please use path or some function in fsx module to get the filename from a pathname.

raj-vlabs · 2021-06-07T12:39:43Z

validation/validate.js

+      validateSchema(json, schema);
+      break;
+    default:
+      console.log("Error");


Default case should print the usage options

raj-vlabs · 2021-06-09T10:00:17Z

validation/schemas/quizv2Schema.js

+          correctAnswer: {
+            type: "string",
+          },
+          difficulty: {


You need to limit the possible values of difficulty to the three values

raj-vlabs · 2021-06-09T10:00:50Z

validation/schemas/quizv2Schema.js

+            type: "object",
+          },
+          correctAnswer: {
+            type: "string",


This can be only one of a b c or d, you need to restrict the scope of possible values.

raj-vlabs · 2021-06-09T10:09:58Z

validation/validate.js

+    let filepath = path.resolve(argv.files[0]);
+    if (!fs.existsSync(filepath)) {
+      console.log(filepath);
+      throw new Error("File does not exist");


Put the full filepath in the error message so the user knows which file doesn't exist

raj-vlabs · 2021-06-23T03:49:53Z

validation/schemas/quizSchema.js

+    properties: {
+      version: {
+        type: "integer",
+        enum: [2],


Would it be better to specify the full version number (like 2.1) son anyone reading the code gets the idea that the version can be in major.minor format.

Yup sir agreed, changed accordingly.

raj-vlabs · 2021-06-23T03:50:56Z

validation/schemas/quizSchema.js

+        errorMessage: "Version should be 2.0",
+      },
+    },
+    if: { properties: { version: { const: 2 } }, required: ["version"] },


Instead of writing an if clause for each new version, can we move the version:schema map into a separate object so we do not need to touch the code in order to add a new version?

As we had discussed, the schema doesn't allow me to properly implement that.

raj-vlabs · 2021-06-23T03:52:44Z

validation/validate.js

@@ -4,8 +4,14 @@ const AjvErrors = require("ajv-errors");
 const path = require("path");
 const fs = require("fs");
 const schemaMap = require("./schema-map.json");
+const qv1Schema = require("./schemas/qv1.json");
+const qv2Schema = require("./schemas/qv2.json");


Same suggestion as above. if we move the version to schema map in a separate variable, we can just import the relevant file based on the version and when we add another version in future, we will not need to touch this file

I'll convert this into an array inclusion

raj-vlabs · 2021-06-29T04:12:26Z

validation/schemas/qv1.json

+      },
+      "answers": {
+        "type": "object",
+        "minProperties": 1,


I'd think minimum no of answers should be 2, at least one incorrect. Do you see a use case for only the correct answer?

* Show that the versioning supports major.minor

Add base for validation

9ad3993

* Referencing #25

raj-vlabs requested changes Jun 4, 2021

View reviewed changes

raj-vlabs reviewed Jun 4, 2021

View reviewed changes

vjspranav added 8 commits June 7, 2021 13:04

Inital yargs implemetnation

aff33f4

* schemaMap.json -> schema-map.json

Add initial validation

126aa6b

* npm run validate-schema -f prestest.json * npm run validate-schema -f pretest.json posttest.json * npm run validate-schema -f test.json -s ./schemas/quizv2Schema.js

Working on custom errors

7b9face

Add support for custom error validation

d444011

Add more custom error messages

78f2b2f

Working implementations of v1 and v2 schema

1cdf3f1

Conditional implementation

267bfa3

Major update

99cca6e

* Support for conditional version * Reference schema from external files

raj-vlabs requested changes Jun 29, 2021

View reviewed changes

vjspranav added 3 commits July 6, 2021 13:53

Make schema inclusion generic

525ddfe

* Show that the versioning supports major.minor

Make sure there is at least one question and at least two answers

a383ab0

Merge branch 'dev' into validation

8bedc85

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] JsonSchema Validation #26

[WIP] JsonSchema Validation #26

vjspranav commented Jun 4, 2021

raj-vlabs left a comment

raj-vlabs Jun 4, 2021

raj-vlabs Jun 4, 2021

raj-vlabs Jun 4, 2021

raj-vlabs Jun 7, 2021

raj-vlabs Jun 7, 2021

raj-vlabs Jun 9, 2021

raj-vlabs Jun 9, 2021

raj-vlabs Jun 9, 2021

raj-vlabs Jun 23, 2021

vjspranav Jul 6, 2021

raj-vlabs Jun 23, 2021

vjspranav Jul 6, 2021

raj-vlabs Jun 23, 2021

vjspranav Jul 6, 2021

raj-vlabs Jun 29, 2021

[WIP] JsonSchema Validation #26

Are you sure you want to change the base?

[WIP] JsonSchema Validation #26

Conversation

vjspranav commented Jun 4, 2021

raj-vlabs left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment