Polkadot Release v1.5.0 migration #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olanod
reviewed
Jan 3, 2024
| } | ||
|
|
||
| fn kreivo_live_genesis( | ||
| fn genesis( |
There was a problem hiding this comment.
Would this produce the same genesis we used to launch the chain?
| .build() | ||
| } | ||
|
|
||
| pub fn kreivo_kusama_chain_spec() -> ChainSpec { |
There was a problem hiding this comment.
This function should return the "live chainspec" but it's using test data like the "UNIT" token and the test_genesis. I believe this should keep returning the same chainspec as the one registered in the relay chain.
node/src/command.rs
Outdated
| @@ -94,7 +87,7 @@ macro_rules! construct_async_run { | |||
| #[cfg(all(feature = "virto-runtime", not(feature = "kreivo-runtime")))] | |||
There was a problem hiding this comment.
should we remove this including the virto-runtime feature?
|
@olanod the PR is still in draft , there are many things that will be fixed once the PR becomes active :) |
- [node/chain_spec:kreivo]: allowed dead_code on unused functions + removed useless .into() calls - [node/chain_spec:service]: comment out unused import - [runtime]: comment out unused imports
olanod
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.