Change virtiofs service Name and DisplayName #24
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23
Previously we were essentially doing:
sc create "Virtio FS Service" ... DisplayName=VirtioFsSvc
but now we're essentially doing:
sc create VirtioFsSvc ... DisplayName="Virtio FS Service"
The previous behavior was confusing because it made all future
interacting with the service (using tools such as
sc
) look like theservice's DisplayName was being specified where the command actually
expects (requires!) the service's Name to be specified.
Note that this commit uses "VirtioFsSvc" as the service Name instead of
"VirtioFSService". That's for consistency with the instructions that
people have been using when following:
https://virtio-fs.gitlab.io/howto-windows.html
This commit also adds a "Description" field to help people determine
what the service is for when they encounter it in the Services app, for
example.
Signed-off-by: Jonathan Watt [email protected]