Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change virtiofs service Name and DisplayName #24

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

jwatt
Copy link
Contributor

@jwatt jwatt commented Dec 6, 2021

Fixes #23

Previously we were essentially doing:

sc create "Virtio FS Service" ... DisplayName=VirtioFsSvc

but now we're essentially doing:

sc create VirtioFsSvc ... DisplayName="Virtio FS Service"

The previous behavior was confusing because it made all future
interacting with the service (using tools such as sc) look like the
service's DisplayName was being specified where the command actually
expects (requires!) the service's Name to be specified.

Note that this commit uses "VirtioFsSvc" as the service Name instead of
"VirtioFSService". That's for consistency with the instructions that
people have been using when following:

https://virtio-fs.gitlab.io/howto-windows.html

This commit also adds a "Description" field to help people determine
what the service is for when they encounter it in the Services app, for
example.

Signed-off-by: Jonathan Watt [email protected]

@ovirt-infra
Copy link
Collaborator

Hello contributor, thanks for submitting a PR for this project!

I am the bot who triggers "standard-CI" builds for this project.
As a security measure, I will not run automated tests on PRs that are not from white-listed contributors.

In order to allow automated tests to run, please ask one of the project maintainers to review the code and then do one of the following:

  1. Type ci test please on this PR to trigger automated tests for it.
  2. Type ci add to whitelist on this PR to trigger automated tests for it and also add you to the contributor white-list so that your future PRs will be tested automatically. ( keep in mind this list might be overwritten if the job XML is refreshed, for permanent whitelisting, please follow Installer fails to start VdService on Windows 2016 after virt-v2v conversion #3 option )
  3. If you are planning to contribute to more than one project, maybe it's better to ask them to add you to the project organization, so you'll be able to run tests for all the organization's projects.

Fixes virtio-win#23

Previously we were essentially doing:

  sc create "Virtio FS Service" ... DisplayName=VirtioFsSvc

but now we're essentially doing:

  sc create VirtioFsSvc ... DisplayName="Virtio FS Service"

The previous behavior was confusing because it made all future
interacting with the service (using tools such as `sc`) look like the
service's DisplayName was being specified where the command actually
expects (requires!) the service's Name to be specified.

Note that this commit uses "VirtioFsSvc" as the service Name instead of
"VirtioFSService". That's for consistency with the instructions that
people have been using when following:

  https://virtio-fs.gitlab.io/howto-windows.html

This commit also adds a "Description" field to help people determine
what the service is for when they encounter it in the Services app, for
example.

Signed-off-by: Jonathan Watt <[email protected]>
@vrozenfe vrozenfe merged commit 4a29a8d into virtio-win:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VirtIO-FS Service's Name and DisplayName seem inverted
3 participants