Agent: sigterm children #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remi-espie
force-pushed
the
feat/sigterm_children
branch
from
ff67591 to
577670e
Compare
mfernd
reviewed
May 1, 2024
remi-espie
force-pushed
the
feat/sigterm_children
branch
3 times, most recently
from
b0fe690 to
f91d524
Compare
…ception Signed-off-by: ESPIE <[email protected]>
Signed-off-by: ESPIE <[email protected]>
…be non blocking Signed-off-by: ESPIE <[email protected]>
Signed-off-by: ESPIE <[email protected]>
Signed-off-by: Mateo Fernandez <[email protected]>
remi-espie
force-pushed
the
feat/sigterm_children
branch
from
3bfd951 to
4f61ad8
Compare
MurielParaire
pushed a commit
to MurielParaire/cloudlet
that referenced
this pull request
May 3, 2024
* feat: child processes are now gracefully sigterm-ed on kill signal reception Signed-off-by: ESPIE <[email protected]> * chore: merge from main Signed-off-by: ESPIE <[email protected]> * fix: changed `std::process::Command` to `tokio::process::Command` to be non blocking Signed-off-by: ESPIE <[email protected]> * chore: cargo fmt Signed-off-by: ESPIE <[email protected]> * refactor: use async_trait instead of Pin<Box<Future<>>> Signed-off-by: Mateo Fernandez <[email protected]> --------- Signed-off-by: ESPIE <[email protected]> Signed-off-by: Mateo Fernandez <[email protected]> Co-authored-by: Mateo Fernandez <[email protected]> Signed-off-by: Muriel Paraire <[email protected]>
MurielParaire
pushed a commit
to MurielParaire/cloudlet
that referenced
this pull request
May 3, 2024
* feat: child processes are now gracefully sigterm-ed on kill signal reception Signed-off-by: ESPIE <[email protected]> * chore: merge from main Signed-off-by: ESPIE <[email protected]> * fix: changed `std::process::Command` to `tokio::process::Command` to be non blocking Signed-off-by: ESPIE <[email protected]> * chore: cargo fmt Signed-off-by: ESPIE <[email protected]> * refactor: use async_trait instead of Pin<Box<Future<>>> Signed-off-by: Mateo Fernandez <[email protected]> --------- Signed-off-by: ESPIE <[email protected]> Signed-off-by: Mateo Fernandez <[email protected]> Co-authored-by: Mateo Fernandez <[email protected]> Signed-off-by: Muriel Paraire <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR now handle better the
signalreceived by the vmm to gracefully shut down children processes by sending them a sigterm and waiting for them before exiting the process.More type of signal could be interpreted and sent easily to the children processes.