Add command to queue packages #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robin5605
requested review from
shenanigansd,
sid-maddy,
import-pandas-as-numpy and
jonathan-d-zhang
If the Dragonfly API returns a 409, then make another request to check if the package has results already. If it does, then simply display those results. If it doesn't, then that means the package is currently in a "queued" or "pending" state. We can just send a feedback message saying this in this case.
|
Some suggestions from @import-pandas-as-numpy on Discord:
@import-pandas-as-numpy what do you think about a button on the result message that lets you check if the queued package is done? Something along the lines of a "refresh" button. |
|
After further discussion, we should also add a background task that would periodically check for this package, and update the message with the new results if it's done. |
|
Gonna hold off on the background task thing for now, and do that in a separate PR for the sake of getting this merged. |
The class name was changed in a later commit
jonathan-d-zhang
previously approved these changes
Jul 2, 2024
Instead of creating a new variable `package` assigned to the first item of `scan_results` (or `None` if its' empty), we simply check if the `scan_results` list is not empty - if it's not, use the first item. If it is, display a message to the user. The `package` variable obtained from getting the first item of `scan_results` was unused regardless, so this only made the code harder to read.
import-pandas-as-numpy
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #151