fix: fixes #77 - refunds could not be processed properly because of a…

… mistake when calling the `woocommerce_order_after_calculate_totals` action. We assume the object is always a subscription, when it is not
vippsas · Sep 21, 2023 · 794d1d4 · 794d1d4
1 parent c21cae1
commit 794d1d4
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 5 deletions.
diff --git a/README.txt b/README.txt
@@ -160,6 +160,9 @@ Alternatively you could look into using WooCommerce "Early renewals": [https://d
 
 == Changelog ==
 
+= 1.16.5 =
+* Fixed: Refunds could not be processed properly because of a mistake when calling the `woocommerce_order_after_calculate_totals` action. We assume the object is always a subscription, when it is not.
+
 = 1.16.4 =
 * Fixed: Properly stop checking for a gateway change when a gateway change succeeded.
 

diff --git a/includes/wc-gateway-vipps-recurring.php b/includes/wc-gateway-vipps-recurring.php
@@ -2039,10 +2039,12 @@ public function prevent_backwards_transition_on_completed_order( $status, $order
 		}
 
 		public function update_agreement_price_in_app( $and_taxes, $subscription ) {
-			$payment_method = WC_Vipps_Recurring_Helper::get_payment_method( $subscription );
+			if ( ! wcs_is_subscription( $subscription ) ) {
+				return;
+			}
 
-			if ( $this->id !== $payment_method
-				 || ! wcs_is_subscription( $subscription ) ) {
+			$payment_method = WC_Vipps_Recurring_Helper::get_payment_method( $subscription );
+			if ( $this->id !== $payment_method ) {
 				return;
 			}
 

diff --git a/woo-vipps-recurring.php b/woo-vipps-recurring.php
@@ -5,7 +5,7 @@
  * Description: Offer recurring payments with Vipps for WooCommerce Subscriptions
  * Author: Everyday AS
  * Author URI: https://everyday.no
- * Version: 1.16.4
+ * Version: 1.16.5
  * Requires at least: 4.4
  * Tested up to: 6.3
  * WC tested up to: 8.0
@@ -17,7 +17,7 @@
 
 // phpcs:disable WordPress.Files.FileName
 
-define( 'WC_VIPPS_RECURRING_VERSION', '1.16.4' );
+define( 'WC_VIPPS_RECURRING_VERSION', '1.16.5' );
 
 add_action( 'plugins_loaded', 'woocommerce_gateway_vipps_recurring_init' );