removed global config and static classes #47
Conversation
| return this._accessTokenService; | ||
| } | ||
|
|
||
| public IVippsEpaymentService EpaymentService() |
There was a problem hiding this comment.
Any reason for instantiating the services through functions? Can't they live as members of the VippsApi class, instantiated by the constructor?
There was a problem hiding this comment.
Not anymore, I changed this now. Also did some changes to startup in the Vipps.net.AspCoreDemo, to use the IOptions pattern instead of injecting singleton.
…the services in the constructor
| } | ||
|
|
||
| public Uri BaseAddress | ||
| { | ||
| get { return HttpClient.BaseAddress; } | ||
| get { return new Uri(UrlHelper.GetBaseUrl(_options.UseTestMode)); } |
There was a problem hiding this comment.
This should return the actual HttpClients base address, as a custom HttpClient with a non-default base address can be provided in the constructor. (For example by us to test UAT)
| @@ -6,26 +6,44 @@ | |||
|
|
|||
| namespace Vipps.net.Services | |||
| { | |||
| public static class AccessTokenService | |||
| public interface IVippsAccessTokenService | |||
There was a problem hiding this comment.
Maybe just forgot to rename the file, the file name should be the same as the interface/class (VippsAccessTokenService)
| @@ -6,34 +6,53 @@ | |||
|
|
|||
| namespace Vipps.net.Services | |||
| { | |||
| public static class CheckoutService | |||
| public interface IVippsCheckoutService | |||
There was a problem hiding this comment.
And VippsCheckoutService
| private readonly IVippsEpaymentService _epaymentService; | ||
| private readonly IVippsCheckoutService _checkoutService; | ||
|
|
||
| public VippsApi( |
There was a problem hiding this comment.
Should provide a way to inject a custom HttpClient (if we want to keep the feature, which I assume we are?)
No description provided.