Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create your own conflict #4

Merged
merged 3 commits into from
Mar 19, 2020
Merged

Create your own conflict #4

merged 3 commits into from
Mar 19, 2020

Conversation

github-learning-lab[bot]
Copy link
Contributor

Step 5: Create your own conflict

So far, this pull request doesn't have any conflicts. I have added some new branch protections to prevent you from merging before you're ready.

In the last activity, you solved a merge conflict that someone else created. This time, you'll create the merge conflict yourself.

⌨️ Activity: Make changes on this branch

  1. Click on the Files changed tab in this pull request.
  2. Click octicon-kebab-horizontal in the top right-hand corner of the _data/education.yml file that had been previously modified.
  3. Click Edit file to open the file editor.
  4. Modify the content in the degree:, uni:, year:, and summary: lines.
  5. Scroll to the bottom of the page and enter a commit message for your change.
  6. Click the Commit changes button, making sure the "Commit directly to the add-education branch" option is selected.

Watch below for my response.

violadelbono pushed a commit that referenced this pull request Mar 19, 2020
…9e68c54b83e369

[Snyk] Fix for 1 vulnerabilities
@github-learning-lab github-learning-lab bot mentioned this pull request Mar 19, 2020
@github-learning-lab
Copy link
Contributor Author

Where do conflicts come from?

In a real world scenario, it's possible that a peer or colleague will have edited the same file in the same place as your pull request.

To demonstrate, I'll stand in as your colleague 👋. In this other pull request #2, you'll see that the education file has been changed. The other pull request was just merged to master, which means there's now a conflict in your pull request.

Step 6: Resolve new conflicts

⌨️ Activity: Resolve the conflict

  1. In the "This branch has conflicts that must be resolved" section of the pull request, click Resolve conflicts.

Because you created the conflict, feel free to resolve this conflict as you wish.


Return to this pull request for next steps.

@github-learning-lab
Copy link
Contributor Author

Step 7: Merge the pull request

Great job, @violadelbono, your pull request is free of conflicts. 🎉 Go ahead and merge this pull request now.

⌨️ Activity: Merge this pull request

  1. Click Merge pull request below.
  2. Click Confirm Merge.
  3. Click Delete branch.

Watch below for my response.

@violadelbono violadelbono merged commit 2627412 into master Mar 19, 2020
@github-learning-lab
Copy link
Contributor Author

Yay! You've done it! You've resolved all of the conflicts. I have a few pointers for completing your resume, so I've opened one last issue for that information.


Check out the final issue here!

@violadelbono violadelbono deleted the add-education branch March 19, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants