Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not explicitly build static lib #293

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: do not explicitly build static lib #293

wants to merge 1 commit into from

Conversation

topazus
Copy link
Contributor

@topazus topazus commented Aug 14, 2024

It is better to set BUILD_SHARED_LIBS option to build shared or static lib than to explicitly build the library as static.

@topazus
fix: do not explicitly build static lib
9b926f1 
It is better to set BUILD_SHARED_LIBS option to build shared or static lib than
to explicitly build the library as static.
@zccrs zccrs requested a review from wineee August 19, 2024 06:52
@wineee
Copy link
Member

wineee commented Aug 19, 2024

qwlroots was originally intended to be a header only library, but the remaining small amount of implementation is in cpp
1, 2, using dynamic libraries will not significantly reduce the size of program, and I prefer to build qwlroots as static libraries by default

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wineee wineee Awaiting requested review from wineee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@topazus @wineee