-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Waving #221
base: develop
Are you sure you want to change the base?
Waving #221
Conversation
I think this change is really cool. We might want to make rows toggle so that people can show/hide the ones they want before we add this, unless it fits the app. We should discuss what we plan on doing for columns in the future here. |
The toggle thing is something a bit out of my league. If someone can take that or at least give me hints on how to make it, I can also modify this branch to make it work along that feature |
My two cents on what would be my ideal roadmap:
With all this said, we could still add things the wrong way and hide them using CSS. We could even add some checkboxes on the app settings to disable any given column. My problem with this approach is it would probably have an impact on performance because everything would still be there (it wouldn't if we only add a few more columns). Hiding the name column in the child species table would be as easy as adding this to our CSS file:
|
* Update hashingKey placeholder wording * Add support for display options * Add shiny sprites for Magikarp and Gyarados * Load sprite based on gender and shiny
Fix candy name
This pull provide 2 new columns.
The first one is made by 2 parameters:
-NWD = No Waving Damage (per Sec) is the actual DPS done by your pokemon per second just by spamming your quick attack
-PWD = Perfect Waving Damage (per Sec) is the actual DPS done by your pokemon per second using also your charge moves.
The second one is
-PWD% = Perfect Waving Damage (per Sec) Rating is the actual rating based on the best Waving damage of the current pokemon.
Been made just by 2 characters, this last parameter is supposed to be used as a renaming pattern in future change.