-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Landing Page Design instance-6 #229
base: master
Are you sure you want to change the base?
Landing Page Design instance-6 #229
Conversation
…debase Frontend/react codebase
Updating README.md
I had updated the changes needed.
Update private property in package.json
Added FAQ's in home.html
Added necessary space
…o#201) Add animated landing page design (Instance vinitshahdeo#8)
Add landing page design Instance vinitshahdeo#4
Updated Footer
Landing Page Design
New Landing Page Design
Figma based design for Instance vinitshahdeo#3
Landing Page Design in AdobeXD (Instance vinitshahdeo#7)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please tell me what steps you followed? It seems you always get stuck while creating a PR. There are so many unwanted commits attached to this PR.
Please let us know which commands you are trying and what are their corresponding outputs.
git checkout feature/frontend. |
Have you performed |
Yes I used git pull upstream command but didn’t checked git log |
@habeeba-naaz Please resolve merge conflicts and resubmit for review. |
Description
Please review these design images placed in screenshots folder instance and let me know any changes to be done.
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.
Fixes #172
Type of change
Please delete options that are not relevant.
Checklist:
Reviewer: Vinit Shahdeo