Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Logo for the Project #112

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Added Logo for the Project #112

wants to merge 1 commit into from

Conversation

animeshsrivastava24
Copy link

Fixes #21
Please review the added logo.

@auto-assign auto-assign bot requested a review from vinitshahdeo March 3, 2020 22:29
@PragatiVerma18
Copy link
Contributor

PragatiVerma18 commented Mar 7, 2020 •
edited by unfurl-links bot
Loading

Hi @animeshsrivastava24!! Happy to see that you wish to contribute to our project, but your changes can't be seen directly on GitHub. Please follow these links to properly upload images to GitHub:

ardalis
When working with GitHub on things like ReadMe.md files, it’s often helpful to include pictures. Unfortunately, when editing markdown files online, there’s no built-in capability to add images: Typically, this would mean you would need to create an image yourself and commit it into your repository somewhere so you could then reference it. It’s much …
Gist
A guide on how to upload images to GitHub's CDN through issue and pull request text fields. - CDN.md

PragatiVerma18
PragatiVerma18 suggested changes Mar 7, 2020
View reviewed changes
Copy link
Contributor

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binary file not shown.
I can see only this. Please make sure you have added the image properly to GitHub.

PragatiVerma18
PragatiVerma18 suggested changes Apr 2, 2020
View reviewed changes
Copy link
Contributor

@PragatiVerma18 PragatiVerma18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make a PR to the feature/documentation branch and not master for design purposes. Add your design to the Resources folder.

@PragatiVerma18
Copy link
Contributor

@animeshsrivastava24 please be active or else I may have to close this PR.

nandikajain
nandikajain suggested changes Oct 11, 2020
View reviewed changes
Copy link
Contributor

@nandikajain nandikajain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good PR.
Please make a PR to feature/documentation so that it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nandikajain nandikajain nandikajain requested changes

@PragatiVerma18 PragatiVerma18 PragatiVerma18 requested changes

@vinitshahdeo vinitshahdeo Awaiting requested review from vinitshahdeo

Assignees

@vinitshahdeo vinitshahdeo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Design a logo [in all formats]
4 participants
@animeshsrivastava24 @PragatiVerma18 @nandikajain @vinitshahdeo