Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test showing bug in incr. interpreter: single-source reachability #422

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

vilterp
Copy link
Owner

@vilterp vilterp commented Oct 5, 2023

Thanks to @rntz

Fixing this will require going full differential dataflow — i.e. keeping an iteration count on each entry in an IndexedMultiSet

Comment on lines 127 to 129
reach{node: "b"}.
reach{node: "c"}.
reach{node: "x"}.
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be empty

@ghost
Copy link

ghost commented Oct 5, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

@netlify
Copy link

netlify bot commented Oct 5, 2023

Deploy Preview for dl-exec-viz ready!

Name Link
🔨 Latest commit 1179146
🔍 Latest deploy log https://app.netlify.com/sites/dl-exec-viz/deploys/651f3c911aa1000008be3fe1
😎 Deploy Preview https://deploy-preview-422--dl-exec-viz.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant