Performance Optimizations #760
Conversation
Set collection properties for chart settings to IReadOnly to allow programmers to enter any valid stack. Added options for Charts to allow for more styling options build into ChartJs
Added documentation Bugfix: nuget package never contained xml documentation. It does now.
CSS generator documentation created Documentation fixes Added XML summary documentation
…t Tabs Added documentation Bugfix: Accordion collapse all AccordionItems causes stack change issues.
2) Added performance improvement for Image as well.
Added documentation Fixed nullref-issues
|
@Lucasharskamp I appreciate 👏 your efforts on this pull request (PR) . This is a very large PR. I don't have any intention of holding up any PRs unless they introduce too many changes. This PR introduces too many changes in one go. I cannot merge this PR as-is. I'll take care of this PR, so don't worry about out-of-sync changes; I'll merge the changes step-by-step. For Light and Dark mode, I'm looking for a better way to implement it. Performance optimization is definitely needed for improvements. Can you share the Accordion bug fix information for my understanding? |
Reminder that these were far smaller but you kept pushing changes, causing me to have to re-merge it with new features. Bit of a snowball effect. |
…nce they were lacking for the CSS generator.
|
Added disabled buttons color/bg color/border color for the CSS generator. |
…start later in the x-axis, for example)
|
@gvreddy04 Merged back with main, fixed some issues in your code in relation to charts. Also: chartdata should be |
|
@gvreddy04 Note: the ''static code fail'' is because I added a new rule, namely that all public interfaces (methods, classes, etc) that end users can use must have XML summaries, and they're lacking on a lot of code. |
…t BEFORE parameters were being set 2) Text fix in demo. You are butchering my beautiful Dutch language
Bugfixes for grids
|
@gvreddy04 updated to 3.0 |
Removed non-bootstrap features Fixed bug causing child content to throw nullrefs if the content are in a error state
…class name stacks, switch statements replaced with dictionaries. Need some drilling for potential bugs
Improved performance for reading parameters, and allow users to differentiate between Class en "class" attributes without causing errors.
Continues from #747
If you let Blazor itself fill the Parameter/CascadingParameter items, it causes a kind of System.Reflection magic which is not great for performance. This is fine for pages or components which aren't used over and over, but for things like buttons this is very performance intensive. By setting the parameters ourselves, pages and components are rendered a tad faster, and this creates a noticable improvement when rendering things like Grids.
Apart from that, this PR contains little changes: more added documentation and a bugfix for AccordionItems.