Improve Hooks #96
Merged
Improve Hooks #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
4350pChris
force-pushed
the
91-improve-hooks
branch
2 times, most recently
from
f77ddfc to
68816cb
Compare
Closed
4350pChris
force-pushed
the
91-improve-hooks
branch
from
c45fc49 to
88e98e1
Compare
|
@brillout I think I'll go ahead with this API if you don't have any objections. |
|
👍 LGTM. Do some users use these hooks? If yes then we should add some |
4350pChris
force-pushed
the
91-improve-hooks
branch
from
74d3c5f to
589e8a4
Compare
Like this? 589e8a4 |
|
Yes, I'd also mention that all packages need to be updated at the same time. (The commit will appear in all three |
|
Also maybe mentioning |
BREAKING CHANGE: All vike-vue packages need to be updated simultaneously. rename `onBeforeMountApp` to `onBeforeRenderClient` and `onAfterRenderSSRApp` to `onAfterRenderHtml` Signed-off-by: Chris-Robin Ennen <[email protected]>
4350pChris
force-pushed
the
91-improve-hooks
branch
from
589e8a4 to
d99ee00
Compare
Lmk if you think this is enough. |
|
It'll probably lead to a couple of users having to spend more time on migration, but I think it's ok. Free free to merge & publish. |
4350pChris
added a commit
that referenced
this pull request
Jun 4, 2024
BREAKING CHANGE: All vike-vue packages need to be updated simultaneously. rename `onBeforeMountApp` to `onBeforeRenderClient` and `onAfterRenderSSRApp` to `onAfterRenderHtml`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
onBeforeMountApptoonBeforeRenderClient