-
-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: useData() #50
Merged
Merged
feat: useData() #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👌 Good idea to use WDYT of 6a87d62? I think we could even do it now and release a breaking change. Making our a life a little easier for replicating this PR to |
Good idea, but I suggest we make it in several PRs:
WDYT? |
👍 Ok good idea
…On Sat 23. Dec 2023 at 23:14, Aurélien Lourot ***@***.***> wrote:
Good idea, but I suggest we make it in several PRs:
1. we land this and release as ***@***.***
2. I create a PR for bati to switch to data() hooks with useData()
(Bati relies on onBeforeRender()+pageProps) (FYI @magne4000
<https://github.com/magne4000>)
3. I create a follow-up PR removing support for onBeforeRender()+
pageProps and we release it as ***@***.***
WDYT?
—
Reply to this email directly, view it on GitHub
<#50 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHVQRURN4AJH4QHY2IT2WTYK5JU5AVCNFSM6AAAAABBBAZV32VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNRYGM3TSMRVGE>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Let me know if you need more time to review this or if this can land. Thanks :) |
👍 Let me have a closer look. |
LGTM :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
useData()
to vike-reactbasic
example toexamples/onBeforeRender
basic
example from usingonBeforeRender
to usingdata
+useData()