Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: disable vike-node dev server in test mode #37

Merged
merged 1 commit into from
Dec 17, 2024
Merged

fix: disable vike-node dev server in test mode #37

merged 1 commit into from
Dec 17, 2024

Conversation

magne4000
Copy link
Member

Fixes #36

@magne4000 magne4000 requested a review from brillout December 17, 2024 10:49
@brillout
Copy link
Member

LGTM

@brillout
Copy link
Member

LGTM

As a temporary fix, I don't know yet if there is better/proper fix.

@magne4000 magne4000 mentioned this pull request Dec 17, 2024
Closed
@magne4000
Copy link
Member Author

LGTM

As a temporary fix, I don't know yet if there is better/proper fix.

Yes this will need more investigation, and probably some deep dive into vitest codebase.

@magne4000 magne4000 merged commit 04cf43d into main Dec 17, 2024
4 checks passed
@magne4000 magne4000 deleted the magne4000/disable-in-test-mode branch December 17, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brillout brillout Awaiting requested review from brillout

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

server keeps restarting while running vitest when vike-node is enabled
2 participants
@magne4000 @brillout