Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#44] Restrict f key shortcut to f key only #45

Merged
merged 1 commit into from
Jan 26, 2022

Conversation

joshuapease
Copy link
Contributor

This tweak prevents our keyboard functions from firing if CTRL or CMD is being pressed.

https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent#properties

@joshuapease joshuapease linked an issue Jan 3, 2022 that may be closed by this pull request
Copy link
Contributor

@gregkohn gregkohn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it 👍
hah just noticed formatting is all over the place in this file in general, oh well

@joshuapease
Copy link
Contributor Author

True true. I'll add a ticket for that #46

@joshuapease
Copy link
Contributor Author

I'm not quite sure what the merging / deployment strategy is for this.

Cool if I click the "big green button"?

@davist11
Copy link
Contributor

davist11 commented Jan 6, 2022

It's setup to autoupdate on packagist https://packagist.org/packages/viget/craft-viget-base

@joshuapease
Copy link
Contributor Author

Nice!

So do the tags trigger the autoupdate on packagist?

@davist11
Copy link
Contributor

davist11 commented Jan 6, 2022

Correct, breakdown here: https://packagist.org/about

@joshuapease joshuapease merged commit aecf1fe into main Jan 26, 2022
@joshuapease joshuapease deleted the jp/44-search-toggle-ctrl-cmd branch January 26, 2022 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Parts Kit] Restrict f key shortcut to f key only
4 participants