Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interstitials: Fix additional asset player creation between assets at start #6914

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Interstitials: Fix additional asset player creation between assets at start #6914

merged 2 commits into from
Dec 17, 2024

Conversation

robwalch
Copy link
Collaborator

This PR will...

  • Fix additional asset player creation between assets at start
  • Update interstitial controller item references when the schedule is updated

Why is this Pull Request needed?

Fixes cases where additional unexpected Interstitial events fire during playback.

Ensures that the bufferingItem and playingItem in hls.interstitialsManager always match items in its schedule.

Are there any points in the code the reviewer needs to double check?

Resolves issues:

Checklist

  • changes have been done against master branch, and PR does not conflict
  • new unit / functional tests have been added (whenever applicable)
  • API or design changes are documented in API.md

@robwalch robwalch added this to the 1.6.0 milestone Dec 14, 2024
@robwalch robwalch merged commit 92b449b into master Dec 17, 2024
17 checks passed
@robwalch robwalch deleted the bugfix/interstitials-buffered-to branch December 17, 2024 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
HLS.js Interstitials
Status: Done
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
1 participant
@robwalch