Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support GRAY & CMYK Jpegs, fix rounding bug #13

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

let-def
Copy link

@let-def let-def commented Dec 14, 2020

First thanks for your work, this approach does wonders especially with texts.

I made a few improvements in my branch that you may be interested in:

  • first I fixed a rounding bug with downsampled chroma (size as a number of block was not computed correctly when dimensions where not aligned modulo 8 and some planes were downsampled)
  • then I added minimal (quick'n'dirty) support for gray files (single component) and CMYK files.

I think these are non standard, but I was given some produced by proprietary software (Adobe maybe), encoded as jpeg files with 4 independent components. Honestly I don't know enough about JPEG standard to know what to think of these. All I care is that jpeg2png worked reasonably well.

@zvezdochiot
Copy link

zvezdochiot commented Dec 14, 2020

@ThioJoe
Copy link

ThioJoe commented Oct 5, 2024

Patched version worked for me for images that were giving errors before

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants