fix: fixed behaviour with $autoDirty and $rewardEarly when depend…

…ency change
victorgarciaesgi · Dec 14, 2024 · 876f349 · 876f349
1 parent 8514474
commit 876f349
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 2 deletions.
diff --git a/packages/core/src/core/useRegle/useStateProperties/createReactiveFieldStatus.ts b/packages/core/src/core/useRegle/useStateProperties/createReactiveFieldStatus.ts
@@ -96,6 +96,10 @@ export function createReactiveFieldStatus({
                   $pending: scopeState.$pending,
                   $valid: scopeState.$valid,
                 },
+                modifiers: {
+                  $autoDirty: scopeState.$autoDirty,
+                  $rewardEarly: scopeState.$rewardEarly,
+                },
                 customMessages,
                 rule: ruleRef as any,
                 ruleKey,

diff --git a/packages/core/src/core/useRegle/useStateProperties/createReactiveRuleStatus.ts b/packages/core/src/core/useRegle/useStateProperties/createReactiveRuleStatus.ts
@@ -27,7 +27,10 @@ interface CreateReactiveRuleStatusOptions {
     $valid: Readonly<Ref<boolean>>;
     $error: Readonly<Ref<boolean>>;
   };
-
+  modifiers: {
+    $rewardEarly: ComputedRef<boolean | undefined>;
+    $autoDirty: ComputedRef<boolean | undefined>;
+  };
   customMessages: CustomRulesDeclarationTree | undefined;
   path: string;
   storage: RegleStorage;
@@ -43,6 +46,7 @@ export function createReactiveRuleStatus({
   path,
   storage,
   $debounce,
+  modifiers,
 }: CreateReactiveRuleStatusOptions): $InternalRegleRuleStatus {
   type ScopeState = {
     $active: ComputedRef<boolean>;
@@ -172,7 +176,11 @@ export function createReactiveRuleStatus({
       } satisfies ScopeState;
     })!;
 
-    $unwatchState = watch(scopeState.$params, $validate);
+    $unwatchState = watch(scopeState.$params, () => {
+      if (modifiers.$autoDirty.value || (modifiers.$rewardEarly.value && fieldProperties.$error.value)) {
+        $validate();
+      }
+    });
   }
 
   $watch();

diff --git a/tests/unit/useRegle/properties/$autoDirty.spec.ts b/tests/unit/useRegle/properties/$autoDirty.spec.ts
@@ -11,6 +11,8 @@ import {
   shouldBeValidField,
 } from '../../../utils/validations.utils';
 
+// TODO add test case for dependency change
+
 describe.each([
   ['local modifier', simpleNestedStateWithMixedValidation],
   ['global modifier', simpleNestedStateWithMixedValidationAndGlobalConfig],