Skip to content

Commit

Permalink
🆕 Update ide helper command to work with PHP 8 (#6)
Browse files Browse the repository at this point in the history
  • Loading branch information
victor-falcon authored Mar 31, 2021
1 parent 092bcf3 commit 7533e7a
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 5 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/default.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:

strategy:
matrix:
php: [7.4]
php: [8.0]
laravel: [8.*]
dependency-version: [prefer-lowest, prefer-stable]
os: [ubuntu-latest, windows-latest]
Expand All @@ -27,13 +27,13 @@ jobs:
uses: shivammathur/setup-php@v1
with:
php-version: ${{ matrix.php }}
extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite, bcmath, soap, intl, gd, exif, iconv, imagick
extensions: dom, curl, libxml, mbstring, zip, pcntl, pdo, sqlite, pdo_sqlite, bcmath, soap, intl, gd, exif, iconv, imagick, fileinfo
coverage: none

- name: Install dependencies
run: |
composer require "laravel/framework:${{ matrix.laravel }}" "orchestra/testbench:${{ matrix.testbench }}" --no-interaction --no-update
composer update --${{ matrix.dependency-version }} --prefer-dist --no-interaction --no-suggest
composer update --${{ matrix.dependency-version }} --prefer-dist --no-interaction
- name: Execute tests
run: ./vendor/bin/phpunit
3 changes: 3 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,10 @@
Install via composer

```bash
# PHP >= 8
composer require victor-falcon/laravel-task
# Previous PHP versions
composer require victor-falcon/laravel-task:1.1.4
```

## Usage
Expand Down
2 changes: 1 addition & 1 deletion composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
}
],
"require": {
"php": ">=7.4",
"php": ">=8.0",
"illuminate/support": "^6.0|^7.0|^8.0",
"composer/composer": "^2.0"
},
Expand Down
2 changes: 1 addition & 1 deletion src/Console/Commands/IdeHelpCommand.php
Original file line number Diff line number Diff line change
Expand Up @@ -116,7 +116,7 @@ private function getParameters(\ReflectionMethod $method): array

/** @var \ReflectionParameter $param */
foreach ($method->getParameters() as $param) {
$paramClass = $param->getClass();
$paramClass = $param->getType();
$paramType = $param->getType();

if ($paramClass !== null) {
Expand Down

0 comments on commit 7533e7a

Please sign in to comment.