Dockerfile optimizations #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Why
Ansible is super slow to install, and invalidating the cache on that step every time
manjaro_packagesis changed is a little annoying. Plus, there may be other steps added to that target later which would make the issue worse. Putting it into its own layer that runs as the first step of theinstalltarget means it should only miss cache (almost) only if the base Arch image has changed.When doing interactive tests, having to watch the Zsh and Neovim plugins get installed is annoying. Plus, I'd like these to be part of the build since that's all the CI I'm currently running.