refactor: use http.Redirect for redirect function

vicanso · Sep 17, 2019 · 3e417a8 · 3e417a8
1 parent adaa585
commit 3e417a8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/context.go b/context.go
@@ -213,8 +213,10 @@ func (c *Context) Redirect(code int, url string) (err error) {
 		err = ErrInvalidRedirect
 		return
 	}
+
 	c.StatusCode = code
-	c.SetHeader(HeaderLocation, url)
+	c.Committed = true
+	http.Redirect(c.Response, c.Request, url, code)
 	return
 }
 

diff --git a/context_test.go b/context_test.go
@@ -365,15 +365,17 @@ func TestSignedCookie(t *testing.T) {
 
 func TestRedirect(t *testing.T) {
 	assert := assert.New(t)
+	req := httptest.NewRequest("GET", "/", nil)
 	resp := httptest.NewRecorder()
-	c := NewContext(resp, nil)
+	c := NewContext(resp, req)
 	err := c.Redirect(299, "")
 	assert.Equal(err, ErrInvalidRedirect)
 
 	url := "https://aslant.site/"
 	err = c.Redirect(302, url)
 	assert.Nil(err)
 	assert.Equal(url, c.GetHeader(HeaderLocation))
+	assert.Equal(302, c.StatusCode)
 }
 
 func TestCreate(t *testing.T) {