Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATA-2443: SubmitCustomTrainingJob RPC and custom training related metadata fields #477

Merged
merged 11 commits into from
Apr 19, 2024

Conversation

n0nick
Copy link
Member

@n0nick n0nick commented Apr 12, 2024

No description provided.

@n0nick n0nick changed the title DATA-2443: Add SubmitCustomTrainingJob RPC and custom training related metadata fields DATA-2443: SubmitCustomTrainingJob RPC and custom training related metadata fields Apr 12, 2024
@n0nick n0nick requested a review from tahiyasalam April 12, 2024 19:34
Copy link
Member

@tahiyasalam tahiyasalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small thing! Holding off on approval until changes are made, since once approved and files are generated, it's cumbersome to make more changes (info here)

proto/viam/app/mltraining/v1/ml_training.proto Outdated Show resolved Hide resolved
@n0nick n0nick requested a review from tahiyasalam April 15, 2024 14:38
Copy link
Member

@tahiyasalam tahiyasalam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, might have to rebase with the newest changes and hopefully the new generated file workflow will work for you 😄

@github-actions github-actions bot added the safe to test committer is a member of this org label Apr 17, 2024
@n0nick n0nick added the ready-for-protos add this when you want protos to compile on every commit label Apr 17, 2024
@n0nick n0nick removed the ready-for-protos add this when you want protos to compile on every commit label Apr 17, 2024
@n0nick n0nick added protos-compiled ready-for-protos add this when you want protos to compile on every commit and removed protos-compiled labels Apr 19, 2024
@n0nick n0nick removed the ready-for-protos add this when you want protos to compile on every commit label Apr 19, 2024
@n0nick n0nick merged commit dcd0ae6 into viamrobotics:main Apr 19, 2024
2 checks passed
@n0nick n0nick deleted the DATA-2443 branch April 19, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protos-compiled safe to test committer is a member of this org
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants