-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add BGP as an option for the Kube_VIP #140
base: main
Are you sure you want to change the base?
Conversation
* Feat: Add BGP as an option for the Kube_VIP * AB#9103388 * fix template name * fix template name
* Feat: Add BGP as an option for the Kube_VIP * AB#9103388 * fix template name * fix template name * removed whitespace
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good start but I think personally we shouldn't have two templates, we should use the same template, but since we can have an if statement with Jinja for all the stuff using ARP and the other for BGP, which makes it easier to maintain long term and make sure that fixes apply properly both sides.
* Feat: Add BGP as an option for the Kube_VIP * AB#9103388 * fix template name * fix template name * removed whitespace * made changes per VexxHost Feedback * removed template * fixed variables
* Feat: Add BGP as an option for the Kube_VIP * AB#9103388 * fix template name * fix template name * removed whitespace * made changes per VexxHost Feedback * removed template * fixed variables * fixed template
whitespace
I think for this to land we need two things:
Technically 3 won't even really be necessary.. since it will actually just show up as a route on the system most probably anyways. This will make sure we don't introduce any regressions.. |
Feat: Add BGP as an option for the Kube_VIP
AB#9103388