Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add BGP as an option for the Kube_VIP #140

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

tvanfleet
Copy link

  • Feat: Add BGP as an option for the Kube_VIP

  • AB#9103388

* Feat:  Add BGP as an option for the Kube_VIP

* AB#9103388

* fix template name

* fix template name
* Feat:  Add BGP as an option for the Kube_VIP

* AB#9103388

* fix template name

* fix template name

* removed whitespace
Copy link
Member

@mnaser mnaser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good start but I think personally we shouldn't have two templates, we should use the same template, but since we can have an if statement with Jinja for all the stuff using ARP and the other for BGP, which makes it easier to maintain long term and make sure that fixes apply properly both sides.

.gitignore Outdated Show resolved Hide resolved
roles/kube_vip/defaults/main.yml Outdated Show resolved Hide resolved
roles/kube_vip/defaults/main.yml Outdated Show resolved Hide resolved
roles/kube_vip/defaults/main.yml Outdated Show resolved Hide resolved
roles/kube_vip/defaults/main.yml Outdated Show resolved Hide resolved
roles/kube_vip/defaults/main.yml Outdated Show resolved Hide resolved
roles/kube_vip/templates/kube-vip-bgp.yaml.j2 Outdated Show resolved Hide resolved
* Feat:  Add BGP as an option for the Kube_VIP

* AB#9103388

* fix template name

* fix template name

* removed whitespace

* made changes per VexxHost Feedback

* removed template

* fixed variables
@tvanfleet tvanfleet requested a review from mnaser October 19, 2024 15:56
* template fix

* space :|
* Feat:  Add BGP as an option for the Kube_VIP

* AB#9103388

* fix template name

* fix template name

* removed whitespace

* made changes per VexxHost Feedback

* removed template

* fixed variables

* fixed template
whitespace
@mnaser
Copy link
Member

mnaser commented Nov 15, 2024

I think for this to land we need two things:

  1. Create a molecule scenario that deploys FRR and configures it in a basic way to receive announcements
  2. Run the usual deploy but using BGP instead
  3. Ensure that the VIP is announced via BGP in the FRR config

Technically 3 won't even really be necessary.. since it will actually just show up as a route on the system most probably anyways. This will make sure we don't introduce any regressions..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants