Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing GitHub Actions CI #475

Open
wants to merge 92 commits into
base: main
Choose a base branch
from
Open

Conversation

beau-witter
Copy link

PR Summary

Attempts to fix the failing github actions based on the error message.

Context

The GitHub Actions CI appears to be failing and based on following up on the error message, this change should help.

Changes

  • Change failing reference to known currently specified variables as defined by GitHub

Checklist

  • Pull Request has a meaningful title.
  • Summarised changes.
  • Pull Request is ready to merge & is not WIP.
  • Added tests / only testable interactively.
    • Make sure you add a new test if old tests do not effectively test the code changed.
  • Added documentation / opened issue to track adding documentation at a later date.

Remove more unnecessary references to pesterinfo file
Remove unused dependencies file
Adjust version of Pester in readme
Also show what is located in $env:PROJECTROOT/PSKoans and what is in $env:BUILTMODULEPATH
GitHub env acts differently when set in the yml
Also adds printout of all env variables
It seems that scripts need to have their environment variables passed in from the actions yaml
Also clean up some of the unused debugging
Flattens if/else now that I know which var is the correct one
Also add some output statements for clarity
Also, store the calculated path variable for use in later copying
I am trying to understand how the env variables sometime pass in correct and sometimes are only seemingly visible (when viewing the action output) but not when trying to reference them in code.
Accidentally using powershell syntax instead of github actions
Also corrects all remaining variable references
Fix test results path so the entire workspace is not packaged
Upload code coverage results
revert publish job to as it was
May still be a good idea to update to a non-deprecated action for publishing test results
Also try to output code coverage results for extra information (why does code coverage state 0% when it should currently be around 8%?)
Also remove passthru and adjust output to detailed
Just the Tests folder for where to run from
Just the PSKoans folder for where the source files are.
This should allow Code Coverage to more directly link tests to their respective files
Also chang the variable in the KoanValidation tests to actually print
Also demote output back to Normal from Detailed
Also commented out suspected unneccesary step in the Test job
Also remove sanity debug output
Remove unneccesary docs inclusion in tests
Bump download-artifact to v3 to dismiss warning
@beau-witter
Copy link
Author

I also added a new workflow called ".github/workflows/unit-test-results.yml" that is meant to display the actual code coverage results due to limitations of generating reports on fork PRs as described here: https://github.com/marketplace/actions/publish-test-results#support-fork-repositories-and-dependabot-branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant