Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36935] Implement NewLogger() in FlinkFileSystem #28

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

fredia
Copy link
Collaborator

@fredia fredia commented Jan 6, 2025

What is the purpose of the change

Implement NewLogger() in FlinkFileSystem

Brief change log

  • Implement NewLogger() in FlinkFileSystem, let logger create file via ForStFileSystem.

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

Copy link
Collaborator

@Zakelly Zakelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fredia fredia merged commit aa94693 into ververica:main Jan 6, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants