-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move sudo commands to a new Vertex Kernel #27
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quentinguidee
force-pushed
the
feature/kernel
branch
5 times, most recently
from
September 28, 2023 04:08
5059605
to
0d11c8c
Compare
Signed-off-by: Quentin Guidée <[email protected]>
Because it needs access to port 80.
Signed-off-by: Quentin Guidée <[email protected]>
quentinguidee
force-pushed
the
feature/kernel
branch
from
September 28, 2023 05:04
e534edc
to
dccd300
Compare
Signed-off-by: Quentin Guidée <[email protected]>
quentinguidee
force-pushed
the
feature/kernel
branch
from
September 28, 2023 05:14
dccd300
to
fdbec33
Compare
🚀 |
quentinguidee
added a commit
that referenced
this pull request
Mar 3, 2024
…kages/components/follow-redirects-1.15.5 build(deps): bump follow-redirects from 1.15.3 to 1.15.5 in /packages/components
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new Vertex Kernel executable, which improves security. This way, only some sudo commands are handled by Vertex Kernel, and everything else is handled by Vertex.
How it works
Instead of running
vertex
, we now need to runvertex-kernel
as sudo.vertex-kernel
will then startvertex
by dropping unnecessary privileges and running it as an unprivileged user.To run the vertex-kernel, we need to pass the username of the user that runs vertex. By default, it will pass "vertex" as username.
or
Vertex Kernel will now be able to handle SSH or Docker containers safely.
It is still possible to run Vertex as usual without Vertex-Kernel, but all features that need superuser permissions will not be usable.
Todo
setcap 'cap_net_bind_service=+ep' vertex
, as it needs port 80 for the proxy