Fixes documentation errors and code errors for vertx-core example #444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linghengqian
force-pushed
the
dev-fix
branch
3 times, most recently
from
5477cbb
to
f95db3a
Compare
- Fixes Net Echo SSL example in vertx-core. - Fixes HTTP/2 Push example error in vertx-core. - Fixes HTTP/2 Simple example bug in vertx-core. - Fixes HTTP HTTPs example bug in vertx-core. - Addes error handling to the HTTP/2 Custom Frames example in vertx-core. - Addes main function for HTTP/2 Simple example in vertx-core. - Removes useless handling for Safari browser for HTTP/2 Push example in vertx-core. - Removes io.vertx.example.core.net.greeter package which is not described in README. - Updates all dependencies of example of vertx-core. - Removes introduction to Groovy verticles. - Remove useless io.netty:netty-tcnative-boringssl-static .
|
CC @vietj . |
linghengqian
force-pushed
the
dev-fix
branch
2 times, most recently
from
8114e63
to
17bb16b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Explain here the context, and why you're making that change, what is the problem you're trying to solve.
io.vertx:vertx-core:4.3.5oracle/graalvm-reachability-metadata#117 , BouncyCastle ALPN seems to break native image builds netty/netty#11369 , Unable to initialize BouncyCastleAlpnSslUtils during GraalVM native-image build eclipse-vertx/vert.x#3960 .Conformance:
Your commits should be signed and you should have signed the Eclipse Contributor Agreement as explained in https://github.com/eclipse/vert.x/blob/master/CONTRIBUTING.md
Please also make sure you adhere to the code style guidelines: https://github.com/vert-x3/wiki/wiki/Vert.x-code-style-guidelines