added vertx heroku gradle example #284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dalgarins
changed the title
|
What's the difference with the existing Heroku examples? Is it only the build system? |
|
The other example is with maven, this is an example with Gradle, and I have some problems trying that, that's why I published it. |
|
@dalgarins thanks Definitely a nice contrib, not sure if we want to maintain same examples for two build systems. wdyt @vietj ? |
|
Ok, I can create this example in the heroku folder and inside can exist maven example and Gradle example. And I can the new pull request. If you want. |
|
Hold the horses 😁
Let's see what @vietj thinks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is an example to deploy vert.x with gradle in heroku.
this is the example running: https://dry-citadel-56219.herokuapp.com/