Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a vert.x cluster option. #227

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a vert.x cluster option. #227

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ...-hazelcast/src/main/java/io/vertx/examples/spring/clustering/hazelcast/VertxProducer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,11 @@ public class VertxProducer {

@PostConstruct
void init() throws ExecutionException, InterruptedException {
VertxOptions options = new VertxOptions()
.setClusterManager(new HazelcastClusterManager(hazelcastInstance));
VertxOptions options = new VertxOptions()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update your IDE config to use 2 spaces instead of 4.

.setClusterManager(new HazelcastClusterManager(hazelcastInstance))
.setClustered(true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

.setHAEnabled(true)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed

.setClusterHost("192.168.0.67");// Write your ip address numeric form
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can't do this otherwise no one can run the examples without modifying source. You could introduce a Spring config property for cluster host. If not set, setClusterHost would not be called

CompletableFuture<Vertx> future = new CompletableFuture<>();
Vertx.clusteredVertx(options, ar -> {
if (ar.succeeded()) {
Expand Down