Fix issue with Pokemon type emojis being empty if pulled form Pokemon…

… from game master. (#289)
versx · Jun 23, 2022 · 53d9f7d · 53d9f7d
1 parent 0c34765
commit 53d9f7d
Show file tree

Hide file tree

Showing 3 changed files with 19 additions and 4 deletions.
diff --git a/src/Data/GameMaster.cs b/src/Data/GameMaster.cs
@@ -110,6 +110,10 @@ public static PokedexPokemon GetPokemon(uint pokemonId, uint formId = 0)
             var useForm = /*!pkmn.Attack.HasValue &&*/ formId > 0 && pkmn.Forms.ContainsKey(formId);
             var pkmnForm = useForm ? pkmn.Forms[formId] : pkmn;
             pkmnForm.Name = pkmn.Name;
+            // Check if Pokemon is form and Pokemon types provided, if not use normal Pokemon types as fallback
+            pkmnForm.Types = useForm && (pkmn.Forms[formId].Types?.Count ?? 0) > 0
+                ? pkmn.Forms[formId].Types
+                : pkmn.Types;
             return pkmnForm;
         }
 

diff --git a/src/Services/Webhook/Models/PokemonData.cs b/src/Services/Webhook/Models/PokemonData.cs
@@ -342,6 +342,8 @@ public PokemonData()
 
         #endregion
 
+        #region Public Methods
+
         /// <summary>
         /// Set despawn times because .NET doesn't support Unix timestamp
         /// deserialization to <seealso cref="DateTime"/> class by default.
@@ -426,6 +428,10 @@ public async Task<DiscordWebhookMessage> GenerateEmbedMessageAsync(AlarmMessageS
             };
         }
 
+        #endregion
+
+        #region Private Methods
+
         private async Task<dynamic> GetPropertiesAsync(AlarmMessageSettings properties)
         {
             var pkmnInfo = GameMaster.GetPokemon(PokemonId, FormId);
@@ -629,5 +635,7 @@ private async Task<dynamic> GetPropertiesAsync(AlarmMessageSettings properties)
             };
             return dict;
         }
+
+        #endregion
     }
 }
diff --git a/src/WhMgr.csproj b/src/WhMgr.csproj
@@ -76,10 +76,6 @@
     <None Remove="ClientApp\public\index.html" />
   </ItemGroup>
 
-  <ItemGroup>
-    <Folder Include="Web\Api\Requests\" />
-  </ItemGroup>
-
   <ItemGroup>
     <Content Remove="ClientApp\package.json" />
     <Content Remove="ClientApp\package-lock.json" />
@@ -96,6 +92,13 @@
 	  <CopyToOutputDirectory>PreserveNewest</CopyToOutputDirectory>
 	</Content>
   </ItemGroup>
+
+  <ItemGroup>
+    <Compile Remove="Web\Api\Requests\**" />
+    <Content Remove="Web\Api\Requests\**" />
+    <EmbeddedResource Remove="Web\Api\Requests\**" />
+    <None Remove="Web\Api\Requests\**" />
+  </ItemGroup>
   <ItemGroup>
     <None Include="..\README.md">
       <Pack>True</Pack>