fix: Sets uploadable files limit to 5 GiB for PutObject and UploadPar… #981
+79
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This won't automatically run in continuous integration without approval. A member of the Versity organization must allow it. |
| return actionHandler(s, testName, func(s3client *s3.Client, bucket string) error { | ||
| obj := "my-obj" | ||
|
|
||
| _, err := putObjectWithData(5*1024*1024*1024+1, &s3.PutObjectInput{ // more than 5 Gib |
There was a problem hiding this comment.
I think this is too large for github actions to handle. Maybe we need a separate test group for larger tests that we cant run automated in actions?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #961
Sets an upper limit of 5 GiB (as specified in the AWS documentation) on incoming data for large data actions such as PutObject and UploadPart.
Since wrapBodyReader is used to combine the request body reader with other io.Reader instances, a new io.Reader is layered on top to enforce the data size limit.