Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: unmarshal should based on type of golang #137

Merged
merged 9 commits into from
Mar 25, 2024
Merged

fix: unmarshal should based on type of golang #137

merged 9 commits into from
Mar 25, 2024

Conversation

bytemain
Copy link
Member

@bytemain bytemain requested a review from aooohan March 22, 2024 09:30
aooohan
aooohan requested changes Mar 25, 2024
View reviewed changes
internal/luai/example_test.go Outdated Show resolved Hide resolved
@bytemain
Copy link
Member Author

wait, i found the test skip many things

@bytemain bytemain changed the title fix: unmarshal should based on type of golang WIP: fix: unmarshal should based on type of golang Mar 25, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 65.21739% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 35.94%. Comparing base (02dec8e) to head (a47540e).

Files Patch % Lines
internal/luai/decode.go 71.42% 4 Missing ⚠️
internal/luai/encode.go 55.55% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #137      +/-   ##
==========================================
+ Coverage   35.31%   35.94%   +0.62%     
==========================================
  Files          26       26              
  Lines        2384     2398      +14     
==========================================
+ Hits          842      862      +20     
+ Misses       1459     1450       -9     
- Partials       83       86       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bytemain bytemain changed the title WIP: fix: unmarshal should based on type of golang fix: unmarshal should based on type of golang Mar 25, 2024
@aooohan aooohan merged commit 44443bf into main Mar 25, 2024
5 checks passed
@aooohan aooohan deleted the fix/encoding-int branch March 25, 2024 07:49
aooohan added a commit that referenced this pull request Mar 26, 2024
@aooohan
# This is a combination of 10 commits.
038dd9b 
# This is the 1st commit message:

fix: manifest url

# This is the commit message #2:

doc(readme): add roadmap

# This is the commit message #3:

doc(readme): add roadmap

# This is the commit message #4:

feat: support loong64 arch

fix #142

# This is the commit message #5:

ci: add coverage and codecov (#138)

* ci: add coverage and codecov

* ci: fix testcases

* ci: test all cases

* ci: fix testcase on ubuntu

* ci: add macos and windows

* ci: show err

* ci: update ci

* ci: fix testcase

* ci: cancel previous run

* ci: skip case on windows

* ci: update workflow
# This is the commit message #6:

fetch plugin from registry

# This is the commit message #7:

remove author field

# This is the commit message #8:

Load the corresponding hook when calling

# This is the commit message #9:

revert

# This is the commit message #10:

chore: smplified code

fix: unmarshal should based on type of golang (#137)

* fix: unmarshal should based on type of golang

* fix: encoding map[int] will cause error

* chore: update comment

* test: update testcase

* test: update testcase

* Update internal/luai/example_test.go

* test: fix testcases

* test: fix testcases

---------

Co-authored-by: Han Li <[email protected]>

mod

fix: separate processing of PATH, ensuring order and de-duplication.

fix #144 #74

fix: test

Refactor: Load new template plugins and be compatible with old formats (#136)

* Refactoring plugin loading mechanism, support for both old and new templates

* fix: manifest url

* remove author field

* Load the corresponding hook when calling

* revert

* mod

add plugin from registry

bugfix

udpate plugin from registry

udpate plugin from registry

bugfix
aooohan added a commit that referenced this pull request Mar 26, 2024
@aooohan
# This is a combination of 10 commits.
ef9587d 
# This is the 1st commit message:

fix: manifest url

# This is the commit message #2:

doc(readme): add roadmap

# This is the commit message #3:

doc(readme): add roadmap

# This is the commit message #4:

feat: support loong64 arch

fix #142

# This is the commit message #5:

ci: add coverage and codecov (#138)

* ci: add coverage and codecov

* ci: fix testcases

* ci: test all cases

* ci: fix testcase on ubuntu

* ci: add macos and windows

* ci: show err

* ci: update ci

* ci: fix testcase

* ci: cancel previous run

* ci: skip case on windows

* ci: update workflow
# This is the commit message #6:

fetch plugin from registry

# This is the commit message #7:

remove author field

# This is the commit message #8:

Load the corresponding hook when calling

# This is the commit message #9:

revert

# This is the commit message #10:

chore: smplified code

fix: unmarshal should based on type of golang (#137)

* fix: unmarshal should based on type of golang

* fix: encoding map[int] will cause error

* chore: update comment

* test: update testcase

* test: update testcase

* Update internal/luai/example_test.go

* test: fix testcases

* test: fix testcases

---------

Co-authored-by: Han Li <[email protected]>

mod

fix: separate processing of PATH, ensuring order and de-duplication.

fix #144 #74

fix: test

Refactor: Load new template plugins and be compatible with old formats (#136)

* Refactoring plugin loading mechanism, support for both old and new templates

* fix: manifest url

* remove author field

* Load the corresponding hook when calling

* revert

* mod

add plugin from registry

bugfix

udpate plugin from registry

udpate plugin from registry

bugfix
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aooohan aooohan aooohan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: 0.2.5 search java error
2 participants
@bytemain @aooohan