-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mfe): v2->v1 & make version optional #9787
Merged
tknickman
merged 3 commits into
main
from
tomknickman/fdrtn-634-make-version-optional-in-turborepos-config-parsing
Jan 24, 2025
Merged
feat(mfe): v2->v1 & make version optional #9787
tknickman
merged 3 commits into
main
from
tomknickman/fdrtn-634-make-version-optional-in-turborepos-config-parsing
Jan 24, 2025
+183
−394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chris-olszewski
approved these changes
Jan 24, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can get rid of the failing MFE_CONFIG_PKG
test as it exercises behavior that we no longer support from original v1.
tknickman
deleted the
tomknickman/fdrtn-634-make-version-optional-in-turborepos-config-parsing
branch
January 24, 2025 16:40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
V1 config is removed, and V2 config is renamed to V1. Also the version field is optional, defaulting to v1.
I left a lot of the plumbing in place for multiple versions because I'm sure more will come as we continue to improve it.
Testing Instructions