Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mfe): v2->v1 & make version optional #9787

Conversation

tknickman
Copy link
Member

Description

V1 config is removed, and V2 config is renamed to V1. Also the version field is optional, defaulting to v1.
I left a lot of the plumbing in place for multiple versions because I'm sure more will come as we continue to improve it.

Testing Instructions

@tknickman tknickman requested a review from a team as a code owner January 24, 2025 04:04
Copy link

vercel bot commented Jan 24, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 4:18pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 4:18pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 4:18pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 4:18pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 4:18pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 4:18pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 4:18pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 4:18pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2025 4:18pm

Copy link
Member

@chris-olszewski chris-olszewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can get rid of the failing MFE_CONFIG_PKG test as it exercises behavior that we no longer support from original v1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants