Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): add lockfile package changes to affectedPackage #9639

Merged
merged 3 commits into from
Jan 3, 2025
Merged

feat(query): add lockfile package changes to affectedPackage #9639

merged 3 commits into from
Jan 3, 2025

Conversation

chris-olszewski
Copy link
Member

@chris-olszewski chris-olszewski commented Dec 20, 2024 •
edited
Loading

Description

Add added and removed fields for lockfile changes to show exactly why a workspace package was marked as changed due to a lockfile change.

Testing Instructions

query {
  affectedPackages() {
    length
    items {
      name
      reason {
        ... on LockfileChanged {
          added {
            items {
              name
            }
          }
          removed {
            items {
              name
            }
          }
          
        }
      }
    }
  }
}

Results:

...
      {
          "name": "@repo/package",
          "reason": {
            "added": {
              "items": []
            },
            "removed": {
              "items": [
                {
                  "name": "[email protected]"
                }
              ]
            }
          }
        },

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 23, 2024 4:51pm

@chris-olszewski chris-olszewski mentioned this pull request Dec 23, 2024
Closed
@chris-olszewski chris-olszewski marked this pull request as ready for review December 23, 2024 16:55
@chris-olszewski chris-olszewski requested a review from a team as a code owner December 23, 2024 16:55
NicholasLYang
NicholasLYang approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@NicholasLYang NicholasLYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Maybe add a test to either tests/query.rs or via prysk?

@chris-olszewski chris-olszewski merged commit bcfeb89 into main Jan 3, 2025
36 checks passed
@chris-olszewski chris-olszewski deleted the olszewski/feat_lockfile_queries branch January 3, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicholasLYang NicholasLYang NicholasLYang approved these changes

@tknickman tknickman Awaiting requested review from tknickman tknickman is a code owner automatically assigned from vercel/turbo-oss

@dimitropoulos dimitropoulos Awaiting requested review from dimitropoulos dimitropoulos is a code owner automatically assigned from vercel/turbo-oss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chris-olszewski @NicholasLYang