Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SWC relay Wasm plugin #8218

Merged
merged 2 commits into from
May 28, 2024
Merged

Update SWC relay Wasm plugin #8218

merged 2 commits into from
May 28, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented May 27, 2024

Description

Fixes vercel/next.js#64890

When eagerEsModule is used, the SWC relay plugin prepends the import statements, and it made server actions transform think "use server" is not the first statement.

Testing Instructions

I added tests to swc-project/plugins#306

@kdy1 kdy1 self-assigned this May 27, 2024
@kdy1 kdy1 requested review from a team as code owners May 27, 2024 06:16
@kdy1 kdy1 requested review from mehulkar and codybrouwers May 27, 2024 06:16
Copy link

vercel bot commented May 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 27, 2024 6:16am
9 Ignored Deployments
Name Status Preview Comments Updated (UTC)
examples-basic-web ⬜️ Ignored (Inspect) May 27, 2024 6:16am
examples-designsystem-docs ⬜️ Ignored (Inspect) May 27, 2024 6:16am
examples-gatsby-web ⬜️ Ignored (Inspect) May 27, 2024 6:16am
examples-kitchensink-blog ⬜️ Ignored (Inspect) May 27, 2024 6:16am
examples-native-web ⬜️ Ignored (Inspect) May 27, 2024 6:16am
examples-svelte-web ⬜️ Ignored (Inspect) May 27, 2024 6:16am
examples-tailwind-web ⬜️ Ignored (Inspect) May 27, 2024 6:16am
examples-vite-web ⬜️ Ignored (Inspect) May 27, 2024 6:16am
rust-docs ⬜️ Ignored (Inspect) May 27, 2024 6:16am

Copy link
Contributor

🟢 Turbopack Benchmark CI successful 🟢

Thanks

Copy link
Contributor

github-actions bot commented May 27, 2024

⚠️ CI failed ⚠️

The following steps have failed in CI:

  • Turbopack Rust tests (mac/win, non-blocking)

See workflow summary for details

@kdy1 kdy1 merged commit 32e4789 into main May 28, 2024
55 of 58 checks passed
@kdy1 kdy1 deleted the kdy1/swc-core-0-92-3 branch May 28, 2024 13:57
wbinnssmith added a commit to vercel/next.js that referenced this pull request May 28, 2024
wbinnssmith added a commit to vercel/next.js that referenced this pull request May 28, 2024
ForsakenHarmony pushed a commit to vercel/next.js that referenced this pull request Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Relay support does not work with multiple artifact directories
2 participants