Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(examples): add example-with-angular #8140

Merged
merged 13 commits into from
Jan 1, 2025

Conversation

codexshell
Copy link
Contributor

@codexshell codexshell commented May 14, 2024

Description

A new example template utilizing Angular has been added to the examples directory.
This template serves as a reference implementation for projects looking to integrate Angular with the turbo repo ecosystem.

Screenshots

Web
Docs

Testing Instructions

@codexshell codexshell requested review from anthonyshew and a team as code owners May 14, 2024 21:43
@turbo-orchestrator turbo-orchestrator bot added area: ci area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage owned-by: turborepo labels May 14, 2024
Copy link

vercel bot commented May 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
examples-basic-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2025 6:17am
examples-designsystem-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2025 6:17am
examples-gatsby-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2025 6:17am
examples-kitchensink-blog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2025 6:17am
examples-native-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2025 6:17am
examples-nonmonorepo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2025 6:17am
examples-svelte-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2025 6:17am
examples-tailwind-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2025 6:17am
examples-vite-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 1, 2025 6:17am

Copy link

vercel bot commented May 14, 2024

@codexshell is attempting to deploy a commit to the Vercel Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

socket-security bot commented May 14, 2024

New dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@angular-devkit/[email protected] environment, filesystem, network, shell, unsafe Transitive: eval +81 44.7 MB google-wombot
npm/@angular-eslint/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +15 7.34 MB jameshenry
npm/@angular-eslint/[email protected] None +9 3.71 MB jameshenry
npm/@angular-eslint/[email protected] None +7 3.44 MB jameshenry
npm/@angular-eslint/[email protected] Transitive: environment, eval, filesystem, network, shell, unsafe +15 7.4 MB jameshenry
npm/@angular-eslint/[email protected] None +2 1.63 MB jameshenry
npm/@angular/[email protected] None 0 1.73 MB google-wombot
npm/@angular/[email protected] environment, filesystem, network, shell, unsafe Transitive: eval +43 15.7 MB google-wombot
npm/@angular/[email protected] None 0 11.4 MB google-wombot
npm/@angular/[email protected] Transitive: environment, filesystem, unsafe +5 5.85 MB google-wombot
npm/@angular/[email protected] None 0 10.1 MB google-wombot
npm/@angular/[email protected] None 0 28.8 MB google-wombot
npm/@angular/[email protected] None 0 1.91 MB google-wombot
npm/@angular/[email protected] None 0 87.6 kB google-wombot
npm/@angular/[email protected] None 0 758 kB google-wombot
npm/@angular/[email protected] None 0 2.34 MB google-wombot
npm/@types/[email protected] None 0 57.8 kB types
npm/@typescript-eslint/[email protected] None +6 4.5 MB jameshenry
npm/@typescript-eslint/[email protected] None +6 4.5 MB jameshenry
npm/@typescript-eslint/[email protected] None +4 1.38 MB jameshenry
npm/@typescript-eslint/[email protected] None +4 1.38 MB jameshenry
npm/[email protected] filesystem 0 393 kB sgravrock
npm/[email protected] environment, filesystem 0 29.6 kB karmarunnerbot
npm/[email protected] None +2 2.4 MB karmarunnerbot
npm/[email protected] None 0 8.84 kB dfederm
npm/[email protected] Transitive: filesystem +1 408 kB karmarunnerbot
npm/[email protected] environment, filesystem, network, shell +17 2.89 MB karmarunnerbot
npm/[email protected] environment, filesystem Transitive: eval, shell, unsafe +18 28.6 MB alan.agius4
npm/[email protected] None 0 32.4 MB typescript-bot
npm/[email protected] None 0 2.01 MB google-wombot

View full report↗︎

@codexshell codexshell force-pushed the example/with-angular branch 3 times, most recently from 9b23d4d to cd0a6a6 Compare May 17, 2024 10:41
A new example template utilizing Angular has been added to the
'examples' directory. This template serves as a reference implementation
for projects looking to integrate Angular with the turbo repo ecosystem.
@codexshell codexshell force-pushed the example/with-angular branch from cd0a6a6 to 550a130 Compare May 17, 2024 18:11
Copy link
Contributor

@arlyon arlyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the pack side

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Initial change that I'll need to ask for is removing the changed in .github/actions. Taking a look at the example itself now...

Copy link
Contributor

@anthonyshew anthonyshew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my first time ever running an Angular application so I don't know if my expectations are incorrect. But if I make changes in the ui package, I don't see hot reloads in the application. Is that expected? Or should we be seeing live updates?

examples/with-angular/turbo.json Outdated Show resolved Hide resolved
examples/with-angular/package.json Outdated Show resolved Hide resolved

/** @type {import("eslint").Linter.Config} */
module.exports = {
extends: ['eslint:recommended', 'prettier', 'eslint-config-turbo'],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
extends: ['eslint:recommended', 'prettier', 'eslint-config-turbo'],
extends: ['eslint:recommended', 'prettier', 'turbo'],

This should be only turbo instead of eslint-config-turbo. This was a bug we had in the rest of the examples, so don't blame you for following what we did.

Make sure to run the turbo run lint command to make sure it runs successfully!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All requested changes will be ready before Monday. Starting work on them

@anthonyshew
Copy link
Contributor

@SocketSecurity ignore-all

@anthonyshew
Copy link
Contributor

Made the needed updates so we can get this merged in. Thanks for working on this! 🚀

@anthonyshew anthonyshew enabled auto-merge (squash) January 1, 2025 06:21
@anthonyshew anthonyshew disabled auto-merge January 1, 2025 08:04
@anthonyshew anthonyshew merged commit 65b07cb into vercel:main Jan 1, 2025
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: examples Improvements or additions to examples needs: triage New issues get this label. Remove it after triage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs: Add an example for Angular
3 participants