-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(examples): add example-with-angular
#8140
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@codexshell is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
9b23d4d
to
cd0a6a6
Compare
A new example template utilizing Angular has been added to the 'examples' directory. This template serves as a reference implementation for projects looking to integrate Angular with the turbo repo ecosystem.
cd0a6a6
to
550a130
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving on the pack side
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
Initial change that I'll need to ask for is removing the changed in .github/actions. Taking a look at the example itself now...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is my first time ever running an Angular application so I don't know if my expectations are incorrect. But if I make changes in the ui
package, I don't see hot reloads in the application. Is that expected? Or should we be seeing live updates?
|
||
/** @type {import("eslint").Linter.Config} */ | ||
module.exports = { | ||
extends: ['eslint:recommended', 'prettier', 'eslint-config-turbo'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extends: ['eslint:recommended', 'prettier', 'eslint-config-turbo'], | |
extends: ['eslint:recommended', 'prettier', 'turbo'], |
This should be only turbo
instead of eslint-config-turbo
. This was a bug we had in the rest of the examples, so don't blame you for following what we did.
Make sure to run the turbo run lint
command to make sure it runs successfully!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All requested changes will be ready before Monday. Starting work on them
@SocketSecurity ignore-all |
Made the needed updates so we can get this merged in. Thanks for working on this! 🚀 |
Description
A new example template utilizing Angular has been added to the
examples
directory.This template serves as a reference implementation for projects looking to integrate Angular with the turbo repo ecosystem.
Screenshots
Testing Instructions