Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for legacy server npm modules #7898

Merged
merged 1 commit into from
Jul 11, 2019
Merged

Conversation

Timer
Copy link
Member

@Timer Timer commented Jul 11, 2019

Notably, this PR fixes faunadb which relies on formidable.

n.b. formidable is an unmaintained legacy npm package that uses practices not compatible with the modern ecosystem.

Closes #7888
Fixes #7850

At the time of this issue, the widespread use of this package deems this permissible IMO:
image

Notably, this PR fixes `faunadb` which relies on `formidable`.

n.b. `formidable` is an unmaintained legacy npm package that uses practices not compatible with the modern ecosystem.
@Timer Timer added this to the 9.0.1 milestone Jul 11, 2019
@github-actions
Copy link
Contributor

Stats from current PR

Click to expand stats
zeit/next.js canary Timer/next.js legacy-modules Change
Build Duration 14.7s 14.5s -220ms
node_modules Size 45.4 MB 45.4 MB ⚠️ +738 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.45 kB 8.45 kB
Client _error gzip Size 3.24 kB 3.24 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.76 kB 4.76 kB
Client pages/link gzip Size 2.03 kB 2.03 kB
Client pages/routerDirect Size 423 B 423 B
Client pages/routerDirect gzip Size 306 B 306 B
Client pages/withRouter Size 435 B 435 B
Client pages/withRouter gzip Size 301 B 301 B
Client main Size 24.2 kB 24.2 kB
Client main gzip Size 7.97 kB 7.97 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.5 kB 59.5 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Base Rendered Size 1.36 kB 1.36 kB
Build Dir Size 756 kB 756 kB
Click to expand serverless stats
zeit/next.js canary Timer/next.js legacy-modules Change
Build Duration 15.3s 15.4s ⚠️ +78ms
node_modules Size 45.4 MB 45.4 MB ⚠️ +738 B
Total Bundle (main, webpack, commons) Size 210 kB 210 kB
Total Bundle (main, webpack, commons) gzip Size 68.8 kB 68.8 kB
Client _app Size 2.39 kB 2.39 kB
Client _app gzip Size 1.08 kB 1.08 kB
Client _error Size 8.45 kB 8.45 kB
Client _error gzip Size 3.24 kB 3.24 kB
Client pages/index Size 296 B 296 B
Client pages/index gzip Size 222 B 222 B
Client pages/link Size 4.76 kB 4.76 kB
Client pages/link gzip Size 2.03 kB 2.03 kB
Client pages/routerDirect Size 423 B 423 B
Client pages/routerDirect gzip Size 306 B 306 B
Client pages/withRouter Size 435 B 435 B
Client pages/withRouter gzip Size 301 B 301 B
Client main Size 24.2 kB 24.2 kB
Client main gzip Size 7.97 kB 7.97 kB
Client commons Size 183 kB 183 kB
Client commons gzip Size 59.5 kB 59.5 kB
Client webpack Size 1.49 kB 1.49 kB
Client webpack gzip Size 770 B 770 B
Serverless pages/link Size 338 kB 338 kB
Serverless pages/link gzip Size 86.7 kB 86.7 kB ⚠️ +1 B
Serverless pages/index Size Error getting size Error getting size
Serverless pages/index gzip Size Error getting size Error getting size
Serverless pages/_error Size 328 kB 328 kB
Serverless pages/_error gzip Size 84 kB 84 kB ⚠️ +1 B
Serverless pages/routerDirect Size 329 kB 329 kB
Serverless pages/routerDirect gzip Size 84.3 kB 84.3 kB ⚠️ +2 B
Serverless pages/withRouter Size 329 kB 329 kB
Serverless pages/withRouter gzip Size 84.2 kB 84.2 kB
Build Dir Size 1.94 MB 1.94 MB

@Timer Timer merged commit 13cf664 into vercel:canary Jul 11, 2019
@Timer Timer deleted the legacy-modules branch July 11, 2019 17:03
@vercel vercel locked as resolved and limited conversation to collaborators Feb 1, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants