Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DevOverlay] Fix Cross logo warning from next-logo #75120

Open
wants to merge 1 commit into
base: canary
Choose a base branch
from
Open

[DevOverlay] Fix Cross logo warning from next-logo #75120

wants to merge 1 commit into from
+2 −2

Conversation

cuquo
Copy link

@cuquo cuquo commented Jan 20, 2025 •
edited
Loading

What?

replace clip-rule with clipRule and fill-rule with fillRule in Cross component

Why?

it was throwing an error in the new DevOverlay
image

@ijjk
Copy link
Member

ijjk commented Jan 20, 2025

Allow CI Workflow Run

  • approve CI run for commit: 41fc685

Note: this should only be enabled once the PR is ready to go and can only be enabled by a maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
type: next
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cuquo @ijjk